dev/core#2772 - Don't crash for custom fields of type int that are multi-select

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2772

Can't save a record that has a value entered into a custom field of type int which is a dropdown multi-select.

Before

1. Create a custom field of type int.
2. Make it a dropdown.
3. Check the box for multiselect.
4. Create a record and fill in a selection for the custom field.
5. Save.

CRM_Core_Exception: One of parameters (value: ☐1☐) is not of the type Timestamp in .../CRM/Core/DAO.php on line 1713

After

Saves.

Technical Details

is_multiple is for the custom_group and whether it can have multiple instances of the group.
serialize is for the field and specifies multi-select.

Comments

This same issue was supposedly fixed in 5.35 (https://lab.civicrm.org/dev/core/-/issues/2423), but I've tested 5.35.2 and it doesn't work there either.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I'm a little unsure what to do about the last set of fails. They're situations where CustomValueTable::store() has been called directly but without looking up the serialize value from the field definition. (And I haven't tested but I'd argue that the existing hiding missing is_multiple with ?? is wrong here - you want it to be whatever the group definition says, not arbitrarily pick single if you haven't specified.)

[colemanw]

Maybe ?? CRM_Core_DAO::getFieldValue(...)

[colemanw]

This looks great now and tests are happy with it too.

[demeritcowboy]

Thanks!