SearchKit - Allow random sorting (Fixes dev/report#75) #21177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@colemanw just wondering if its possible to get a test on this maybe just testing that RAND() gets added sensibly to the query? |
|
Ok added a test @seamuslee001 |
|
@colemanw I just tested this & it seems fine. One thing - I hadn't spotted that sort box before - is it new? Or did I just miss it. I feel like it should be a multiselect rather than single select This is mergeable once you have responded (one way or another) to ^^ |
|
It was there already, hidden in plain sight :). And it does allow you to select multiple fields to sort by. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows search displays to be sorted in random order.
https://lab.civicrm.org/dev/report/-/issues/75