dev/core#2717 Use order api for new membership create in batch

[eileenmcnaughton]

Overview

dev/core#2717 Use order api for new membership create in batch

Before

Batch membership create calls membership bao directly

After

As with the back office membership form it calls the order api

Technical Details

@kcristiano this is really how I think the code should wind up looking for this flow (although the renew flow still needs more work.) It really does surface the setting of the end date though as the order flow expectst that all 3 dates will be set when it is in pending status. I have fixed it to that in the BAO - but it does mean it's not possible to avoid setting it if I do it this way.

I guess I could only pass in date fields if they are populated - which would cause the BAO to otherwise set them, That might be where I end up as I think we can treat the failure to set end_date as a bug.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[kcristiano]

@eileenmcnaughton I've done a number more r-run In all cases this PR is an improvement. It works as expected and anything I'd want o 'fix' is an improvement. Mostly the missing Transaction ID field and the fact that source only updates the membership entity not the contribution entity. The areas I want improved are not regressions, they work the same way on 5.39-5.41.

This looks good to merge.

[eileenmcnaughton]

@seamuslee001 can you merge based on ^^

[eileenmcnaughton]

thanks @kcristiano @seamuslee001