Use convenience function for one-off token evaluations to avoid too-long filenames and possible privacy issues #21140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses conversation at #21064 (comment) and uses same idea as in #16733
Before
Filename like this, that also possibly unnecessarily caches personal info.
templates_c/en_US//%%27/27E/27EEDEE2%%string%3A%0A++++++first+name+%3D+Alice%0A++++++receive_date+%3D+February+1st%2C+2015+12%3A00+AM%0A++++++contribution+status+id+%3D+1%0A++++++new+style+status+%3D+Completed%0A++++++new+style+label+%3D+Completed+Label%2A%2A%0A++++++id+1%0A++++++contribution_id++-+not+valid+for+action+schedule%0A++++++cancel+date+August+9th%2C+2021+12%3A00+AM%0A++++++source+SSF%0A++++++legacy+source+%0A++++++financial+type+id+%3D+1%0A++++++financial+type+name+%3D+Donation%0A++++++financial+type+label+%3D+Donation%0A++++++payment+instrument+id+%3D+4%0A++++++payment+instrument+name+%3D+Check%0A++++++payment+instrument+label+%3D+Check%0A++++++non_deductible_amount+%3D+%E2%82%AC+10.00%0A++++++total_amount+%3D+%E2%82%AC+100.00%0A++++++net_amount+%3D+%E2%82%AC+95.00%0A++++++fee_amount+%3D+%E2%82%AC+5.00.php
After
Filename looks something like
eval+var%3D%24smartySingleUseString.php
Technical Details
Comments
Has test in the sense it came up during a form of stress-testing with the tests and at least one of them calls this.