fix crmValidate() not loading on event registration pages

[MegaphoneJon]

Overview

There is a logic error in #20543 that prevents the CiviCRM-specific client-side validation loading on event registration pages (and probably elsewhere).

Before

crmValidate() not loading.

After

crmValidate() loading.

Comments

My understanding if #20543 is:

• It's a refactor in that it's not intended to have any noticeable effect;
• The goal is to ensure that we're not attempting to access uninitialized variables, array elements, etc.

I think this fix satisfies both.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[MegaphoneJon]

Oh:

Steps for replication

• Visit an event registration page.
• Open the browser's Dev Toolbar.
• On the "inspector" tab, search for crmValidate.

Also flagging that the regression is new to 5.40.0.

[eileenmcnaughton]

I agree with your analysis

[eileenmcnaughton]

5.40 port #21128