[NFC] {Test} Minor cleanup #21116
[NFC] {Test} Minor cleanup #21116
Conversation
|
(Standard links)
|
| @@ -1288,7 +1282,7 @@ public function testCreateContributionPendingOnline() { | |||
| $this->assertEquals($contribution['values'][$contribution['id']]['trxn_id'], 12345); | |||
| $this->assertEquals($contribution['values'][$contribution['id']]['invoice_id'], 67890); | |||
| $this->assertEquals($contribution['values'][$contribution['id']]['source'], 'SSF'); | |||
| $this->assertEquals($contribution['values'][$contribution['id']]['contribution_status_id'], 2); | |||
| $this->assertEquals(2, $contribution['values'][$contribution['id']]['contribution_status_id']); | |||
There was a problem hiding this comment.
OK - I realise all the lines above need the same change - I decided after the first one not to get carried away
| @@ -316,7 +310,7 @@ public function testGetContributionReturnFunctionality(): void { | |||
| // update contribution with invoice number | |||
| $params = array_merge($params, [ | |||
| 'id' => $contributionID, | |||
| 'invoice_number' => CRM_Utils_Array::value('invoice_prefix', Civi::settings()->get('contribution_invoice_settings')) . "" . $contributionID, | |||
| 'invoice_number' => Civi::settings()->get('invoice_prefix') . $contributionID, | |||
There was a problem hiding this comment.
I can see the original was copy/paste from elsewhere, hence the extra . "". In other languages I've seen sometimes you need to do this type of thing to force string, since maybe a prefix like 0001 got output as just 1, although that doesn't seem to be true in php. But maybe something along those lines, I just can't think what.
But specifically for this test, isn't the prefix always null and known to be such? Not a blocker just was probably also part of copy/paste in the original.
There was a problem hiding this comment.
@demeritcowboy yeah I guess if I'd thought it through further I would have removed it
Overview
[NFC] {Test} Minor cleanup
Before
After