Afform - Store submissions in a new database table #21105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
371a75f to
7ce7523
Compare
a9f6576 to
03383dc
Compare
|
I originally created this PR because I thought it a prerequisite for uploading files, but I now think that data can be passed via JWT. So this could be an opt-in behavior and not all forms need to save their submissions. |
03383dc to
eb856c3
Compare
eb856c3 to
7f5e049
Compare
|
@seamuslee001 I've added a setting to make logging submissions optional, per @totten's suggestion, which should make this easier to merge. |
|
thanks @colemanw I'll take a look shortly |
This adds the `civicrm_afform_submission` table and accompanying api entity, and a new Afform setting "create_submission" which will store a submission record whenever a form is submitted.
7f5e049 to
e6772fc
Compare
colemanw
commented
Aug 24, 2021
| PRIMARY KEY (`id`), | ||
| CONSTRAINT FK_civicrm_afform_submission_contact_id FOREIGN KEY (`contact_id`) REFERENCES `civicrm_contact`(`id`) ON DELETE SET NULL | ||
| ) | ||
| ENGINE=InnoDB ROW_FORMAT=DYNAMIC; |
There was a problem hiding this comment.
@seamuslee001 I manually added ROW_FORMAT=DYNAMIC but in case you want to tackle getting civix to do it...
|
I R-runed this locally and confirmed the upgrade works and confirmed logging works as expected as well MOP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds the
civicrm_afform_submissiontable and accompanying api entity for logging form submissions, and adds a new option: