dev/user-interface#38 Contact Edit: Only display signatures if contact has a CMS account

[mlutfy]

Overview

• Gitlab discussion: https://lab.civicrm.org/dev/user-interface/-/issues/38
• User-interface discussion: https://chat.civicrm.org/civicrm/pl/ptjc1t6qxp8tzkgyrgyzgmdpqy (1 thumbs-up) :)

When editing a contact, we have an option to add an email signature which is then used when sending emails from CiviCRM (via Contact > Actions > Email).

It looks something like this:

Expanding the signature block displays a WYSIWYG and text field to enter an email signature.

This small link is easy to ignore by experienced CiviCRM users, but pretty overwhelming to new CiviCRM users. Not only does expanding explode the UI in a pretty scary way, it's also in an area of CiviCRM that is very overwhelming (location type, On Hold, Mass Mail?, Primary?, Delete).

Before

Email signature is always displayed:

After

Email signature is only displayed if the Contact displayed has a CMS account.

If the contact has a CMS account, the signature works the same as before:

Comments

There was Gitlab discussion that the email signature does not really belong here at all (and I agree), but that's a bigger change and requires more reflexion about the concept of user preferences.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[agileware-justin]

👍 works for us - thanks @mlutfy