Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pear/DB package to be version 1.11.0 #21087

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

Pear DB has been updated to include this patch https://github.com/pear/DB/pull/11/files of CiviCRM's and this upgrades the version we install and updates the patch to be compatible with the new version

Before

Pear DB version 1.10.0 used

After

Pear DB version 1.11.0 used

Plenty of unit tests cover this so if jenkins is happy we should be as well IMO

@civibot
Copy link

civibot bot commented Aug 11, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

It doesn't look like much else is in the release so seems safe pear/DB@v1.10.0...trunk

@eileenmcnaughton eileenmcnaughton merged commit f60c30e into civicrm:master Aug 11, 2021
@eileenmcnaughton eileenmcnaughton deleted the pear_db_upgrade branch August 11, 2021 02:13
@demeritcowboy
Copy link
Contributor

After updating and running composer install (drupal 7), I get

Gathering patches for root package.
Removing package pear/db so that it can be re-installed and re-patched.
  - Removing pear/db (v1.10.0)
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Package operations: 0 installs, 1 update, 0 removals
  - Downloading pear/db (v1.11.0)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
    Update of pear/db failed

  [InvalidArgumentException]
  Package is not installed: pear/db-1.10.0.0

Just running composer install again seems to run fine. I also tried on another install which is reasonably fresh and got the same thing. On a drupal 9 there was no problem but it's a different composer experience where it ignores some things. In vendor/composer/install.json there is a reference to the 1.10.0.0 (with the extra 0 on the end).

I also note this PR updates plugin-api-version to v2 - maybe something related - I vaguely remember a reason it was being held at v1 - for something else maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants