Switch to using apiv4 for metadata #21038
Conversation
|
(Standard links)
|
3219ac7 to
021f3a9
Compare
|
@seamuslee001 this should be a no-change patch that improves readability / switches to apiv4 metadata & has good test cover by now |
021f3a9 to
742941f
Compare
742941f to
29f2b53
Compare
| public function getBAOName(): string { | ||
| return CRM_Core_DAO_AllCoreTables::getFullName(ucfirst($this->getEntityName())); | ||
| protected function getApiEntityName(): string { | ||
| return 'Contribution'; |
There was a problem hiding this comment.
Ok, but why is getEntityName returning a lower-case string in the first place? To be clear, 'contribution' is not the entity name; the correct answer is 'Contribution', Alex.
There was a problem hiding this comment.
I understand the delicacy of not wanting to break things, but IMO it's already broken if it's returning an incorrect string. 'Contribution' isn't just the API entity name, it's the canonical entity name per CRM_Core_DAO_AllCoreTables.
There was a problem hiding this comment.
@colemanw yeah - I might revisit that - but I'd rather not do it in this PR as I'm not comfortable yet about whether it will have a negative impact
|
Ok the entity name can be addressed in a followup. |
Overview
Switch to using apiv4 for metadata - follow up to #21036 which moves some of this stuff to a (potentially temporary) class
Before
Uses BAO metadata
After
Uses apiv4 metadata
Technical Details
I've manually skipped currency for now - which will make this no-change
Comments