Fix bulk adding custom fields with logging on #21019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is only triggered in the 'bulk' writeRecords codepath, not in the createField codepath which is used for creating custom fields via the UI. To replicate: on a wmff build, turn loggin on, check out https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/709873 and run drush update-custom-fields Result prior to this patch: SQL syntax error message and new field not added to logging table Result with this patch: no error message, new field created on log table.
|
(Standard links)
|
|
This looks fine to me merging |
ahed-compucorp
added a commit
to compucorp/civicrm-core
that referenced
this pull request
Nov 24, 2022
Included in CiviCRM 5.41.0 PR: civicrm#21019
ahed-compucorp
added a commit
to compucorp/civicrm-core
that referenced
this pull request
Dec 1, 2022
Included in CiviCRM 5.41.0 PR: civicrm#21019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a SQL error when adding fields to logging tables after bulk saving new CustomFields
To replicate: on a wmff build, turn logging on, check out
https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/709873
and run drush update-custom-fields
Before
SQL syntax error message and new field not added to logging table
After
No error message, field added to logging table
Technical Details
This code is only triggered in the 'bulk' writeRecords codepath,
not in the createField codepath which is used for creating custom
fields via the UI. By sending the 'name' instead of the 'column_name'
the _getColumnQuery's grep was not finding anything matching in the
main table create statement
https://github.com/civicrm/civicrm-core/blob/master/CRM/Logging/Schema.php#L520