Use template variable to add or remove swap button.

[eileenmcnaughton]

Overview

Use template variable to add or remove swap button.

Before

Rendering of 'swap button'

on activity form driven by whether or not the activity assignee field is frozen

After

Presence rendered by a template variable

Technical Details

In combination with email notifications this button can be dangerous - ie an accidental click and
a donor rather than a staff member gets the email.

My thinking is to disable this via the activity assignee extension,
https://lab.civicrm.org/extensions/assignee/-/issues/2 - but it's cleaner for
an extension to intervene by setting a smarty variable than using javascript
to remove the button and I feel like it makes more sense for the form to
assign 'instruction variables' than for the decision to freeze to
also have 'hidden' effects further down

This doesn't wind up being any more supported than the js but it will be easier for us to write a unit test within the extension to ensure it doesn't quietly stop working

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[aydun]

Makes sense to me.

[demeritcowboy]

I'm trying not to think too hard about this. Just noting the limit/freeze/hiding currently only comes into effect on edit.