Smarty warnings on Manage Case

[demeritcowboy]

Overview

Some smarty warnings on Manage Case.

Before

• Notice: Undefined index: hookCaseSummary in include() (line 112 of .../templates_c/en_US/%%64/643/643EC55F%%CaseView.tpl.php).
• Notice: Undefined index: relId in include() (line 231 of .../templates_c/en_US/%%64/643/643EC55F%%CaseView.tpl.php).

After

There's still some more if you have other config like tags, but these are the stock ones.

Technical Details

$relId is mildly interesting. I think it was a mistake when it was added here civicrm/civicrm-svn@8733a55#diff-32e9cc54f42fb47188c658534516a573994fca84ba72f41a11f21261b412f610R174 (it doesn't autoexpand - search the page for CaseView.tpl and then click on Load Diff). Even if the variable were being used in scope, it doesn't make sense to compare $relId to 'client' in the table header because it's a per-row variable (look just down below that at line 179). They probably just copy/pasted from line 190.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).