Switch contribution action schedule tokens to use advertised tokens for cancel_date & source #20999

eileenmcnaughton · 2021-08-02T21:12:02Z

Overview

Scheduled reminders was working with the incorrect and not advertised variants - this
switches over and upgrades ( a bit precautionary since the removed ones were not in the widget)

Before

Tokens in the widget work for letters but not scheduled reminders

After

Tokens in the widget work for both, upgrade script removes references to the old ones

Technical Details

PR incorporates 2 other PRs that can be re-based out

Comments

civibot · 2021-08-02T21:12:05Z

(Standard links)

If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

CRM/Contribute/Tokens.php

…or cancel_date & source Scheduled reminders was working with the incorrect and not advertised variants - this switches over and upgrades ( a bit precautionary since the removed ones were not in the widget)

eileenmcnaughton · 2021-08-03T06:45:33Z

@seamuslee001 this has passed now - yay

eileenmcnaughton · 2021-08-04T02:02:13Z

I just resolved all the above comments as the code discussed in them is no longer in this PR

seamuslee001 · 2021-08-05T21:21:23Z

ok this seems to be right now merging

seamuslee001 · 2021-08-05T21:21:36Z

also unit tests should cover enough here

civibot bot added the master label Aug 2, 2021

eileenmcnaughton force-pushed the act_up branch from b40ad3f to 04c8eb2 Compare August 2, 2021 21:35

eileenmcnaughton added the has-test label Aug 2, 2021

eileenmcnaughton force-pushed the act_up branch from 04c8eb2 to ad990e0 Compare August 2, 2021 22:58

seamuslee001 reviewed Aug 3, 2021

View reviewed changes