Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mailing task when there are no tasks #20989

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Aug 1, 2021

Overview

Same fix for mailings as we did for activities here #20951

Before

Expanding "Mailings" on advanced search gives network error if there are no mailing action tasks.

After

Expanding "Mailings" on advanced search works if there are no mailing action tasks.

Technical Details

Comments

@eileenmcnaughton

@civibot
Copy link

civibot bot commented Aug 1, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I had an issue replicating this - the 'print' task doesn't seem to show for me on the screen I was trying to replicate it on - even though it should.

However, I was able to replicate the error & the fact this fixed it in the end - and the fact that I see no actions ever on this page seems unchanged by this PR - so I'm merging (& quite possibly ignoring )

image

image

@eileenmcnaughton eileenmcnaughton merged commit 9504674 into civicrm:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants