Case Dashboard: fix labels on my/all radio buttons, and simplify label text

[mlutfy]

Overview

The Case dashboard has a radio button to toggle between "My Cases" and "All Case".

Except they are not named that way, nor do they behave like most radio buttons. What you might read below might surprise you. Or not. (/clickbait)

Before

• The toggle does indeed toggle the filters on the lists of "Upcoming Activities", but it's very verbose, and I think most people can figure it out. Not to mention that the listings do have a title that says "My Cases with Upcoming Activities" (or "All Cases with upcoming activities). Most users do not read text unless they really to, so shorter is usually better.
• When we click the text of the radio, it does not select the option. One must precisely click on the round thing.

After

• text is clickable
• label is shorter

Comments

cc @demeritcowboy

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Ahh you made me click. Back at ya:
[clickbait] These words are making people furious: https://github.com/civicrm/civicrm-core/blob/31efa0d6fa9c27f2d86186d78ca5e8e1f4e73689/templates/CRM/Dashlet/Page/CaseDashboard.tpl#L26-42 [/clickbait]

If changing here, then those dashlet version ones should probably be made consistent, but it wouldn't have to be part of this PR. The third one is actually a link to Find Cases not the dashboard.

None of the labels before and after are 100% accurate (it's actually something like cases that have an activity in the next 14 days with status=Scheduled). So maybe the text should say "Surprise me". (grin)

[eileenmcnaughton]

I vote for 'some random cases you may be interested in' or 'people who read your last case also read....'

[demeritcowboy]

I'm conflicted on this. There's no technical issues, it's just whether it's clearer or not. I understand the current is verbose, but the proposed wording might be misleading, e.g. The case dashboard is broken because I clicked "My Cases" but it's missing a lot of them.

Just tossing an idea: something like My Cases (learn more...) where the link goes somewhere TBD. Or maybe a help bubble beside My Cases?

[mlutfy]

@demeritcowboy Sorry about that, I didn't expect to go down a rabbit hole on this one!

I have to admit I did not understand the $myCases variable. I feel like it is being assigned only to avoid setting a default value for the HTML element?

From CRM/Case/Page/DashBoard.php:

    if (!$allCases) {
      $this->assign('myCases', TRUE);
    }
    else {
      $this->assign('myCases', FALSE);
    }

and then the smarty does if/else to set the right default option?

I understand the current is verbose, but the proposed wording might be misleading, e.g. The case dashboard is broken because I clicked "My Cases" but it's missing a lot of them.

I have to admit that my users rarely see the "Upcoming Activities" lists, because they only use the summary (click on all open cases, etc). They do not use scheduled activities much.

If we look at the summary table (number of open cases), the toggle is misleading, because the summary always lists all/my cases, regardless of whether there are upcoming activities.

And then for the lists of upcoming activities, I do feel like the labels of those lists are pretty clear (and I'm not proposing to change them). Just my opinion, of course, and I completely defer to you.

I didn't understand about the dashlets. I had a look at they do not display a my/all filter?

(I am very sleep deprived, apologies if I am missing anything obvious, or if I am not making sense)

[demeritcowboy]

Yes I think one of many problems with the dashboard is that the toggle applies to both the summary section and the sections below, but they don't show the same things, so it's difficult to get wording that describes both accurately. But yeah I can see that because it's at the top, having wording that matches that one maybe should have priority.

So thinking of it that way, it seems fine.

For the dashlets, it's not those dashlets - there's another one called Case Dashboard Dashlet.

Historical note: The dashboard was a draft suggestion of what could go in it, but then got shipped and became THE dashboard. I usually replace it with a custom page or something.

For $mycases, you might be right. I haven't looked. There might be lots of awkward code in there.

[mlutfy]

Oh ok, I had misread the link you had posted, for the dashlet.

I am going to 🙈 for now, because the translations here made my head hurt. It still kind of seems OK, because the links point to search results? (well, ignoring the translation errors)

Thanks for reviewing! :)