Smarty notices for New Activity / New Case for tags for attachments

[demeritcowboy]

Overview

1. Don't create any tags for attachments.
2. Create a regular activity, or create a new case.
3. Smarty notices - the exact set of notices depends on whether you have any tags for other types or not.

Before

Something like

    Notice: Undefined index: tag_1 in include() (line 60 of .../templates_c/en_US/%%3F/3F9/3F9B0555%%attachment.tpl.php).
    Notice: Undefined index: tagsetInfo in include() (line 68 of .../templates_c/en_US/%%3F/3F9/3F9B0555%%attachment.tpl.php).
    Notice: Undefined index: tag_2 in include() (line 116 of .../templates_c/en_US/%%3F/3F9/3F9B0555%%attachment.tpl.php).
    Notice: Undefined index: tag_2 in include() (line 118 of .../templates_c/en_US/%%3F/3F9/3F9B0555%%attachment.tpl.php).
    Notice: Undefined index: tagsetInfo in include() (line 121 of .../templates_c/en_US/%%3F/3F9/3F9B0555%%attachment.tpl.php).
    Notice: Undefined index: tag_3 in include() (line 116 of .../templates_c/en_US/%%3F/3F9/3F9B0555%%attachment.tpl.php).
    Notice: Undefined index: tag_3 in include() (line 118 of .../templates_c/en_US/%%3F/3F9/3F9B0555%%attachment.tpl.php).
    Notice: Undefined index: tagsetInfo in include() (line 121 of .../templates_c/en_US/%%3F/3F9/3F9B0555%%attachment.tpl.php).
    Notice: Undefined index: tag in include() (line 108 of .../templates_c/en_US/%%E8/E8E/E8EBFB02%%Case.tpl.php).

After

There are still some others depending on your config, but this covers the stock install for attachments.

Technical Details

They can be legitimately missing because it's reasonable not to display a tag select widget if you don't have any tags for the type defined.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

thanks @demeritcowboy

[demeritcowboy]

Thanks!