Fix test to use valid financials #20956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
27355f0 to
8814417
Compare
| * | ||
| * @var bool | ||
| */ | ||
| protected $isValidateFinancialsOnPostAssert = TRUE; |
There was a problem hiding this comment.
This opts in the whole class, and then we opt out the 1 test it doesn't work for
| */ | ||
| protected function assertPostConditions(): void { |
There was a problem hiding this comment.
These asserts are now done by the parent if $isValidateFinancialsOnPostAssert = TRUE; is true
Ideally we opt in the class & opt out specific tests as an interim. Moving towards opt in everything & opt out specific tests
8814417 to
db92bcb
Compare
| @@ -3468,8 +3468,6 @@ public function testCompleteTransactionMembershipPriceSet() { | |||
| * @throws \CiviCRM_API3_Exception | |||
| */ | |||
| public function testPendingToCompleteContribution(): void { | |||
| // @todo - figure out why this test is not valid. | |||
| $this->isValidateFinancialsOnPostAssert = FALSE; | |||
There was a problem hiding this comment.
works because of the fix below
| public function testAssignProportionalLineItems() { | ||
| public function testAssignProportionalLineItems(): void { | ||
| // This test doesn't seem to manage financials properly, possibly by design | ||
| $this->isValidateFinancialsOnPostAssert = FALSE; |
There was a problem hiding this comment.
Does this get reset for the tests that come after it?
There was a problem hiding this comment.
@seamuslee001 yep - I just put in a break point in the next test &
|
This seems fine to me, just want to confirm that the postAssert is properly reset for the other tests in the ContributionTest class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix test to use valid financials
Before
Creates contributions and then line items, resulting in invalid financial data in the test set up
After
uses order api
Technical Details
Comments