dev/core#2717 Use Same order ->payment flow for non recurring back of…

[eileenmcnaughton]

Overview

dev/core#2717 Use Same order ->payment flow for non recurring back office memberships as for recurrings

Before

If a recurring contribution is created we use the order api, otherwise magic custom code

After

Consistent use of the order api

Technical Details

Note - I'm expecting a test fail on the first run of this - if there isn't one it might mean that there is a missing piece of test cover as I think doing this change had been blocked by not storing membership_num_terms in the line item table (it never worked for recurrings for mulitiple terms iirc

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton

Form.php:579, After, Priority: High
Expected 1 blank line after function; 2 found

[eileenmcnaughton]

I think the test fails here might actually be 'good' - but I want to get the pre-requisite merged #20941

[eileenmcnaughton]

@monishdeb I just rebased the one you just merged out of this - if you look with no whitespace https://github.com/civicrm/civicrm-core/pull/20936/files?w=1 this is less than it looks - but it alters it to do Order->payment.create for non-recurring card payments.

I'll follow this up with a switch to using the v4 membership api (which I'll add) from within the Order.create api - but I wanted to get this test-cover extension first

[monishdeb]

I have tested on my local, tried different use-cases which touch the code where Order API call is introduced and didn't encounter any breakage/regression. Reviewed the patch. Changes look good and make sense. Merging now.

[eileenmcnaughton]

Thanks @monishdeb !