Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'includes tax' translation for PriceSet Checkbox fields #20926

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Jul 21, 2021

Overview

Fixes the translation of the "includes tax-term of 123$" in PriceSet CheckBox fields.

Bug reported by Maria on the translation channel.

Before

Here you can see that the first option is correctly translated ("incluant"), but not for the checkboxes:

civi-tax-before-2021-07-21_08-35

After

Now all fields translate correctly:

civi-tax-after-2021-07-21_08-44

(I also tested radio-buttons, because I did a bit of unrelated code cleanup)

Comments

I think Jeff Bezos should pay taxes too.

@civibot
Copy link

civibot bot commented Jul 21, 2021

(Standard links)

@demeritcowboy
Copy link
Contributor

Looks good and the reporter has also said in chat that they tested it.

@demeritcowboy demeritcowboy merged commit 2fdadd7 into civicrm:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants