Reduce deadlock while inserting custom data for Address #20924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I'd forgotten all about that change - I took a look & this makes sense in the context of the PR you linked to - will leave it for a little bit for others to look @jaapjansma @mattwire @seamuslee001 - I'd completely forgotten about this as a way to improve deadlocks - but I feel like it might be good to put back in our toolkit - the linked PR explains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reduce deadlocks when processing address with custom data.
Technical Details
Followup PR of #14605
Comments
ping @eileenmcnaughton @JoeMurray