Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display configured currency on PCPPage instead of default #20904

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

mattwire
Copy link
Contributor

Overview

Show correct currency for PCP page.

Before

Default currency in CiviCRM shown

After

Actual currency configured for contribution/pcp page shown:
image

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 19, 2021

(Standard links)

@civibot civibot bot added the master label Jul 19, 2021
@@ -57,6 +57,7 @@ public function run() {

CRM_Utils_System::setTitle($pcpInfo['title']);
$this->assign('pcp', $pcpInfo);
$this->assign('currency', $pcpInfo['currency']);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could use pcp.currency directly on the template but for consistency with all other crmMoney modifiers I'm assigning currency directly to the template.

@mlutfy
Copy link
Member

mlutfy commented Jul 21, 2021

I tested before & after and can confirm that the fix works, and patch makes sense. Thank you @mattwire

@mlutfy mlutfy merged commit 7c97bc4 into civicrm:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants