Relationship view/edit/delete quickform - don't require cid in url params #20883
Conversation
Previously 'cid' was required in addition to 'id' and 'rtype'. The redundant param can be looked up based on relationship id and r_type (direction).
|
(Standard links)
|
| @@ -100,7 +100,7 @@ public function view() { | |||
| $rType = CRM_Utils_Array::value('rtype', $viewRelationship[$this->getEntityId()]); | |||
| // add viewed contribution to recent items list | |||
| $url = CRM_Utils_System::url('civicrm/contact/view/rel', | |||
| "action=view&reset=1&id={$viewRelationship[$this->getEntityId()]['id']}&cid={$this->getContactId()}&context=home" | |||
| "action=view&reset=1&id={$viewRelationship[$this->getEntityId()]['id']}&context=home" | |||
There was a problem hiding this comment.
is rtype needed if we have the relationship id?
There was a problem hiding this comment.
Ideally no - I think @demeritcowboy is suggesting it doesn't work right without it with the code as currently is?
There was a problem hiding this comment.
Right - at the moment the way the destination page works, without rtype you get a mostly blank page when you click the recent items view link.
| @@ -109,6 +109,7 @@ public function getContactId() { | |||
| public function setContactId($contactId) { | |||
| $this->_contactID = $contactId; | |||
| $this->_contactId = $contactId; | |||
| $this->assign('contactId', $this->getContactId()); | |||
There was a problem hiding this comment.
It's not wrong but seems odd to call getContactId() here since already have the id - this was moved from below.
There was a problem hiding this comment.
I've become rather a fan of using getters as much as possible rather than passing around variables. This is rather in response to the fact that variables get passed around a LOT in civi and they can become quite mystical whereas getters always do the same thing wherever they live (although I have a suspicion this getter might be a bit odd)
|
|
|
test this please |
|
@colemanw this seems to be pending response from you |
|
This has merge conflicts and has stalled. I kind of remember this and had a related one of my own somewhere which also stalled. |
Overview
This simplifies the URL arguments needed in the relationship view/edit/delete form.
Before
Three URL args required:
'cid','id'and'rtype'.After
The redundant
'cid'param is looked up based on the other two.Comments
This makes constructing links from SearchKit much simpler, and also fixes a potential buggy situation where leaving the
'cid'param off the url tricks the form into thinking the relationship is for the current user.