Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix functions to be protected #20869

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

I did some poking around & these function are not called outside the class

Once we can see that we can consider updating to save 0 to the table, allowing
a lot of simplification

I did some poking around & these function are not called outside the class

Once we can see that we can consider updating to save 0 to the table, allowing
a lot of simplification
@civibot
Copy link

civibot bot commented Jul 16, 2021

(Standard links)

@civibot civibot bot added the master label Jul 16, 2021
@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

I did a grep across the universe and didn't see any evidence of these functions being called outside of core

@seamuslee001 seamuslee001 merged commit 836da26 into civicrm:master Jul 19, 2021
@seamuslee001 seamuslee001 deleted the acl3 branch July 19, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants