Swap {$displayName} smarty for {contact.display_name} token

[eileenmcnaughton]

Overview

Swap displayName smarty for {contact.display_name token}

This swaps over the smartyToken for the token token on the template added on new installs, and adds a test.

To test make sure you enable invoicing & then generate an invoice from search results.
use the demo site due to aforementioned lack of upgrade and check the display name is still on
the left hand side. There should be no change

Before

{$displayName} used in invoice template

After

{contact.display_name} used on new installs

Technical Details

Separately I will look at an upgrade script and other templates

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I didn't do organization name because in my testing it was only showing up for organizations not individuals which meant it was repeated - but I'll test that further

[mlutfy]

Tangential, but since you mention it - I use invoicing a lot, and never found why the organization name was repeated. if an invoice is "care of Some Person", then it would be in the address fields.

[eileenmcnaughton]

hmm - good point

[seamuslee001]

Jenkins re test this please

[mlutfy]

Tested on the demo & works for me. The extra test is nice.

Just curious: what motivated you to change it?

[eileenmcnaughton]

@mlutfy it's really a preliminary to removing smarty tokens from other places where contact tokens would work - mostly because the code works pretty hard to get those tokens onto the form. In the case of this form it is one of very few places in the code that call the dreaded 'loadRelatedContributions' function and it is getting those contact fields from that function

Also loaded via that awful function is organization_name - as you mention it might be a bit odd how it is used and first_name & last name in the online contribution receipt function - although I think those were removed already from the template

[mlutfy]

@eileenmcnaughton Makes sense. Thank you!