Add ts() function within CRM_Core_Error::statusBounce() method #20857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Intermittent test fail: api.v4.Action.CreateWithOptionGroupTest.testWithCustomDataForMultipleContacts jenkins retest this please |
| @@ -75,7 +75,7 @@ public function run() { | |||
| ) . '.php'; | |||
| $error = include_once $classFile; | |||
| if ($error == FALSE) { | |||
| CRM_Core_Error::statusBounce('Participant listing code file: ' . $classFile . ' does not exist. Please verify your custom particpant listing settings in CiviCRM administrative panel.'); | |||
| CRM_Core_Error::statusBounce(ts('Participant listing code file: %1 does not exist. Please verify your custom particpant listing settings in CiviCRM administrative panel.', [1 => $classFile])); | |||
There was a problem hiding this comment.
I didn't even know this existed! It's a bit technical and seems unlikely to be something a user would deal with - so it's a judgement call I guess whether to include it in translation.
There was a problem hiding this comment.
Also participant is spelled wrong. (particpant)
There was a problem hiding this comment.
Good points - I think I've managed to add a spelling fix - the other is a judgement call as you say & I'm on the side of 'getting this merged'
Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I couldn't translate you have tried to access a report that does not exist text.
Before
Some texts within CRM_Core_Error::statusBounce() method don't have translation function.
After
All CRM_Core_Error::statusBounce() methods have translation function
ts().