-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 2685 #20818
Fix for issue 2685 #20818
Conversation
Can one of the admins verify this patch? |
(Standard links)
|
Jenkins ok to test |
@eileenmcnaughton this I think is a possible intra regression from your $ids work |
Yeah dang - I thought I could switch it to the rc as we should merge to the 5.40 branch but it is NOT clean - @sadashivdalvi are you able to rebase over the 5.40 branch and force push (probably easiest is to git reset --hard origin/5.40 & then just cherry-pick your patch back on - then us -f when pushing to github) |
ok, will rebase over 5.40 and apply this on it. Should I then create a PR from there and we close this PR? |
@sadashivdalvi if you force push onto this current branch it you shouldn't need to re-create the PR |
ok, I did rebase and force push, now you can check and merge. Thanks, |
Issue is reported at https://lab.civicrm.org/dev/core/-/issues/2685