Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 2685 #20818

Merged
merged 1 commit into from
Jul 11, 2021
Merged

Fix for issue 2685 #20818

merged 1 commit into from
Jul 11, 2021

Conversation

sadashivdalvi
Copy link
Contributor

@civicrm-builder
Copy link

Can one of the admins verify this patch?

@civibot
Copy link

civibot bot commented Jul 9, 2021

(Standard links)

@civibot civibot bot added the master label Jul 9, 2021
@seamuslee001
Copy link
Contributor

Jenkins ok to test

@seamuslee001
Copy link
Contributor

@eileenmcnaughton this I think is a possible intra regression from your $ids work

@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.40 July 9, 2021 04:47
@civibot civibot bot added 5.40 and removed master labels Jul 9, 2021
@eileenmcnaughton
Copy link
Contributor

Yeah dang - I thought I could switch it to the rc as we should merge to the 5.40 branch but it is NOT clean - @sadashivdalvi are you able to rebase over the 5.40 branch and force push (probably easiest is to git reset --hard origin/5.40 & then just cherry-pick your patch back on - then us -f when pushing to github)

@sadashivdalvi
Copy link
Contributor Author

ok, will rebase over 5.40 and apply this on it. Should I then create a PR from there and we close this PR?

@seamuslee001
Copy link
Contributor

@sadashivdalvi if you force push onto this current branch it you shouldn't need to re-create the PR

@sadashivdalvi
Copy link
Contributor Author

ok, I did rebase and force push, now you can check and merge.

Thanks,
Sadashiv

@colemanw colemanw merged commit 957d639 into civicrm:5.40 Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants