PHP notice fixes on options page #20816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
commented
Jul 9, 2021
| @@ -229,7 +226,7 @@ public function browse() { | |||
| ); | |||
|
|
|||
| // retrieve financial account name for the payment method page | |||
| if ($gName = "payment_instrument") { | |||
| if ($gName === "payment_instrument") { | |||
There was a problem hiding this comment.
Yikes. This was a typo that caused the condition to always be true!
colemanw
commented
Jul 9, 2021
| @@ -137,7 +137,7 @@ | |||
| <td class="crm-admin-options-description crm-editable" data-field="description" data-type="textarea">{if isset($row.description)}{$row.description}{/if}</td> | |||
| <td class="nowrap crm-admin-options-order">{if isset($row.weight)}{$row.weight}{/if}</td> | |||
| {if !empty($showIsDefault)} | |||
| <td class="crm-admin-options-is_default" align="center">{icon condition=$row.is_default}{ts}Default{/ts}{/icon} </td> | |||
| <td class="crm-admin-options-is_default" align="center">{if !empty($row.is_default)}{icon}{ts}Default{/ts}{/icon}{/if} </td> | |||
There was a problem hiding this comment.
The condition=$row.is_default caused notices, and it's the same as surrounding the whole block in {if}
c322b1d to
bd14fc4
Compare
|
Jenkins test this please |
|
Unrelated failure but still good to have a clean build :) |
|
Jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes php notices, short array syntax, and a bug-begging typo on the Options listing page.
Before
Go to e.g. "Website Types".
Notice the notices.
After
No notices to notice.