Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Remove automatic filter from address #20803

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 7, 2021

Overview

Usability fix for SearchKit - don't automatically add "Location Type" to the search when joining with Address.

Before

When creating a search, adding "With Address" will auto add a filter which may be more confusing than helpful.

After

Filiter not added automatically; still can be added manually.

Comments

This is consistent with other location entities like Email, IM, Phone, etc. which do not auto-add any filters.

Discovered while testing #20746

@civibot
Copy link

civibot bot commented Jul 7, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

I tested & this works

@eileenmcnaughton eileenmcnaughton merged commit 18bb23f into civicrm:master Jul 8, 2021
@eileenmcnaughton eileenmcnaughton deleted the addressSearchFilter branch July 8, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants