[REF] Simplify isRenew handling on batch for membership #20791
Conversation
|
(Standard links)
|
| @@ -733,12 +740,8 @@ private function processMembership(array $params) { | |||
| continue; | |||
| } | |||
| $value['contact_id'] = $params['primary_contact_id'][$key]; | |||
| foreach ($value as $fieldKey => $fieldValue) { | |||
There was a problem hiding this comment.
moved into standardiseRow as this is part of the form-transform to sanity
| @@ -865,10 +866,6 @@ private function processMembership(array $params) { | |||
| * true if mail was sent successfully | |||
| * @throws \CRM_Core_Exception|\API_Exception | |||
| * | |||
| * @deprecated | |||
There was a problem hiding this comment.
this was true before we split the function onto both forms.
|
CRM_Batch_Form_EntryTest::testMembershipRenewalDates |
4492058 to
112eacb
Compare
This starts the process of using getters to get data from the row and also marks the no-longer shared emailReceipt function as no longer deprecated (since it was copied back to this form early). Clean Money moved to 'stdiseRow'
112eacb to
d6dd2be
Compare
|
@monishdeb if you have more time this one is also on my path to cleaning up membership stuff |
| * @return bool | ||
| */ | ||
| private function currentRowIsRenew(): bool { | ||
| return $this->currentRowIsRenewOption === 2; |
There was a problem hiding this comment.
I admit this is not a part of the refactoring change but should that options need to be registered in CRM_Core_SelectValues and later
private function currentRowIsRenew(): bool {
return $this->currentRowIsRenewOption === CRM_Core_SelectValues::membershipModes()['Renew Membership'];
}
There was a problem hiding this comment.
@monishdeb yeah it's been hard enough to figure what it means :-)
Actually the value is distinct to this form I think so we need to make it clear within this class rather than outside the class (I'll keep thinking about ways to do that)
|
r-run passed. The patch looks good. Merging now. |
|
thanks @monishdeb |
Overview
[REF] Simplify isRenew handling on batch for membership
Before
is_renew is set and it is not obvious why
After
Tracked down the usage to email receipt, replaced with a getter
Technical Details
This starts the process of using getters to get data from the row and also
marks the no-longer shared emailReceipt function as no longer deprecated
(since it was copied back to this form early).
Clean Money moved to 'stdiseRow'
I forsee more logic being moved into isRenew as we have some odd stuff to figure it out hidden away
Comments