dev#2861: Prevent duplicate names in mailing labels

[monishdeb]

Overview

Steps to replicate:

1. Go to CiviCRM >> Administration Console >> Address Setting
2. Update the mailing format to

{contact.individual_prefix}{ }{contact.first_name}{ }{contact.last_name}
{contact.organization_name}
{contact.street_address}
{contact.supplemental_address_1}
{contact.supplemental_address_2}
{contact.supplemental_address_3}
{contact.city}{, }{contact.state_province}{ }{contact.postal_code}
{contact.country}

3. Go to Advance search and search for contacts based on any criteria (make sure to include organisation and household in the result)
4. Print mailing labels

https://lab.civicrm.org/dev/core/-/issues/2681

Before

After

Comments

ping @eileenmcnaughton @colemanw

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Looking back through the svn history, the change dates to civicrm/civicrm-svn@6a7f80f#diff-3e6f2e4d6e151f1ade1f80e3463b12e7804643b50a8556e3334ca3f7ac669ba3

Issue: https://issues.civicrm.org/jira/browse/CRM-4575

I'm not clear from the issue description why it was implemented that way, but I certainly think the change in this PR is more correct.

Adding merge-ready tag in case others have input before merging.

[eileenmcnaughton]

I would assume that the reason is because if it is a household label the 'right' field for that household is 'display_name'

However, I suspect in practice the household_name is a drop in replacement for display_name for households and likewise for orgs with organization_name

I tested labels for all 3 types and they seem ok