Support saving more than 25 records in Profile.submit api

[deb1990]

Overview

When we try to Save more than 25 records using Profile.submit api, only 25 records gets saved. This PR fixes that.

Before

Profile.Submit only saves 25 records.

After

Profile.Submit saves all records.

Technical Details

While submitting Profile values, using Profile.submit, the following line gets called, which fetches the fields for current profile.
https://github.com/civicrm/civicrm-core/blob/master/api/v3/Profile.php#L162

Now, internally the _civicrm_api3_buildprofile_submitfields function gets called, which fetches uf_field using https://github.com/civicrm/civicrm-core/blob/master/api/v3/Profile.php#L503. As limit: 0 is not mentioned here, only the first 25 records get returned. Thats why, all the records sent in Profile.submit does not get saved.

To fix this, the same line has been changed to $fields = civicrm_api3('uf_field', 'get', ['uf_group_id' => $profileID, 'options' => ['limit' => 0]]);.

Another alternative would be, to send the limit parameter in Profile.submit api call itself, but as it is a "Create" api call, and we do not need to send limit parameter for other "Create" api calls in CiviCRM, its best that we do the same in this case also, to keep consistency.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

Makes sense. @deb1990 are you still working on this PR?

[deb1990]

@deb1990 No, its ready for review now.

[monishdeb]

Cool. Tested on local, looks good. Merging now.