Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception rather than fatal #20742

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Throw exception rather than fatal #20742

merged 1 commit into from
Jul 1, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 1, 2021 •
edited
Loading

Overview

Throw exception rather than fatal

Before

Fatal error if baoName is not resolved

After

Exception thrown in baoName is not resolved

Technical Details

This makes it easier to debug if the entityName is not
resolved - in general this is a dev site issue as it is
to do with load order

Comments

@eileenmcnaughton
Throw exception rather than fatal
8567ce4 
This makes it easier to debug if the entityName is not
resolved - in general this is a dev site issue as it is
to do with load order
@civibot
Copy link

civibot bot commented Jul 1, 2021

(Standard links)

@civibot civibot bot added the master label Jul 1, 2021
@colemanw
Copy link
Member

colemanw commented Jul 1, 2021

Makes sense.

@colemanw colemanw merged commit a25640f into civicrm:master Jul 1, 2021
@eileenmcnaughton eileenmcnaughton deleted the throw branch October 17, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw