Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enotice fix Remove references to savedFieldMapping in page 2 of the import #20738

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Enotice fix Remove references to savedFieldMapping in page 2 of the import

Before

enotices & extraneous code

After

less of both

Technical Details

I do not believe this is ever assigned and I also don't think it makes sense
if assigned - the first page 'DataSource.tpl' is the one that displays the
option to load a field mapping. This code applies to the second page and
conditionally displays help text which seems to have stopped being true long ago

ie this is from Datasource.tpl
image

And this is what we see on MapField.tpl - being altered here

image

Comments

I do not believe this is ever assigned and I also don't think it makes sense
if assigned - the first page 'DataSource.tpl' is the one that displays the
option to load a field mapping. This code applies to the second page and
conditionally displays help text which seems to have stopped being true long ago
@civibot
Copy link

civibot bot commented Jul 1, 2021

(Standard links)

@civibot civibot bot added the master label Jul 1, 2021
@colemanw
Copy link
Member

colemanw commented Jul 6, 2021

Makes sense; all this does is remove some irrelevant help text.

@colemanw colemanw merged commit b0c6ba6 into civicrm:master Jul 6, 2021
@colemanw colemanw deleted the tpl2 branch July 6, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants