Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpl enotice fix #20735

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Tpl enotice fix #20735

merged 1 commit into from
Jul 1, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 1, 2021

Overview

Fixes a few enotices on the first page of the import process

Before

image

After

thash better

image

Technical Details

I searched for hideStepNumbers & believe it is never assigned

Comments

I searched for hideStepNumbers & believe it is never assigned
@civibot
Copy link

civibot bot commented Jul 1, 2021

(Standard links)

@civibot civibot bot added the master label Jul 1, 2021
@colemanw
Copy link
Member

colemanw commented Jul 1, 2021

I agree, can't find anywhere hideStepNumbers would ever get assigned.

@@ -83,7 +83,7 @@
</tr>
{ /if}

{if $form.disableUSPS}
{if isset($form.disableUSPS)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to be a boolean? Then isset might always be true even if false/0.

Copy link
Contributor

@demeritcowboy demeritcowboy Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nevermind. I was looking at

$this->set('disableUSPS', !empty($this->_params['disableUSPS']));
which isn't confusing at all...

@seamuslee001 seamuslee001 merged commit 5362d1b into civicrm:master Jul 1, 2021
@seamuslee001 seamuslee001 deleted the tpl branch July 1, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants