APIv4 Explorer: show joins for write actions #20731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It recently became possible in APIv4 to use joins during write operations; now that feature is advertised in the Explorer.
Usually it's safe to assume the `id_field` === "id", which is automatically returned by APIv3. However in the case of looking up records by name, etc. we must ensure that value gets returned.
|
(Standard links)
|
|
This seems fine to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Displays information about joins for write operations in the API Explorer.
See #20677 for more about the new feature.
Before
New feature in API but not in API Explorer.
After
Now advertised.
Technical Details
When testing this I found an edge-case bug in the EntityRef widget which was failing to return an entity's
nameif it was requested as theid_field. Fixed in this PR.