Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when sorting case roles table by end date #20728

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

This was just added in #19737 and rather than keep that PR going forever I decided to just do this as a followup.

Before

Depending on your error settings if you try to sort the case roles table on manage case by end date you either get a datatables error or a php warning or silence.

After

No error

Technical Details

end_date needs to be set for the client too otherwise it's missing when it goes to sort by it a couple lines down.

Comments

@civibot
Copy link

civibot bot commented Jun 30, 2021

(Standard links)

@civibot civibot bot added the master label Jun 30, 2021
@colemanw
Copy link
Member

colemanw commented Jul 6, 2021

Looks good.

@colemanw colemanw merged commit e2a9d45 into civicrm:master Jul 6, 2021
@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the missing-end-date branch July 6, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants