Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Minor auth.net ipn simplification #20718

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Minor auth.net ipn simplification

Before

Properties set on $contribution but never used, validation not 'together'

After

Unused properties not set, validation moved closer together

Technical Details

This removes some property setting on the contribution
which is then discarded & moves a bit of validation to be
with the other validation

Comments

@civibot
Copy link

civibot bot commented Jun 28, 2021

(Standard links)

@civibot civibot bot added the master label Jun 28, 2021
This removes some property setting on the contribution
which is then discarded & moves a bit of validation to be
with the other validation
@colemanw
Copy link
Member

Cleanup looks solid. It certainly looks like those variables are never used.

@colemanw colemanw merged commit 012138d into civicrm:master Jul 15, 2021
@colemanw colemanw deleted the ipn branch July 15, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants