APIv4 - Fix same-table joins and remove unused code #20715
Conversation
|
(Standard links)
|
This fixes implicit joins between a table and itself, e.g. the Contact.employer_id which links to the Contact table Also removes alpha code no longer used by APIv4.
| } | ||
|
|
||
| $canBeShorter = empty($path) || count($currentPath) + 1 < count($path); | ||
| $tooFar = $depth > self::MAX_JOIN_DEPTH; |
There was a problem hiding this comment.
@colemanw this seems to be the only thing I wonder about with this, This seems to be something about trying to contort with something in MySQL. Is that replicated somewhere else?
There was a problem hiding this comment.
The long complicated code here was all made to handle a type of join which no longer exists in APIv4.
During alpha development, there was work done to support a pseudo-join where the api would run the main query, collect the ids and do a second query behind-the-scenes to gather e.g. contact.activities. This functionality has been dropped in favor of explicit joins.
|
Tested on my local, works fine on depth > 1 joins. Added unit test captures the behavior on implicit joins accurately. Reviewed code, and ensured that the changing |
Overview
This fixes implicit joins between a table and itself, e.g. the Contact.employer_id which links to the Contact table
Also removes alpha code no longer used by APIv4.
Comments
Adds a test to ensure the join works across multiple entities.