Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Remove POC code leftover from early alpha development #20709

Merged
merged 1 commit into from
Jun 25, 2021
Merged

APIv4 - Remove POC code leftover from early alpha development #20709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
APIv4 - Remove POC code from early alpha 
During early APIv4 development there was an idea to create a BridgeJoinable class and
connect things like activity->assignees.
It was experimentally implemented for that field one field, but never documented or tested.
  • Loading branch information
@colemanw
colemanw committed Jun 25, 2021
commit 4a21520c453bf58d7bcac5fbf6a011cdd9e6a432
50 changes: 0 additions & 50 deletions Civi/Api4/Event/Subscriber/ActivitySchemaMapSubscriber.php
View file
Open in desktop

This file was deleted.

50 changes: 0 additions & 50 deletions Civi/Api4/Service/Schema/Joinable/ActivityToActivityContactAssigneesJoinable.php
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions Civi/Api4/Service/Schema/Joinable/BridgeJoinable.php
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions Civi/Api4/Service/Schema/SchemaMap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@

namespace Civi\Api4\Service\Schema;

use Civi\Api4\Service\Schema\Joinable\BridgeJoinable;

class SchemaMap {

const MAX_JOIN_DEPTH = 3;
Expand All @@ -40,15 +38,6 @@ public function getPath($baseTableName, $targetTableAlias) {

$this->findPaths($table, $targetTableAlias, 1, $path);

foreach ($path as $index => $pathLink) {
if ($pathLink instanceof BridgeJoinable) {
$start = array_slice($path, 0, $index);
$middle = [$pathLink->getMiddleLink()];
$end = array_slice($path, $index, count($path) - $index);
$path = array_merge($start, $middle, $end);
}
}

return $path;
}

Expand Down