Fix undefined tpl vars #20684
Merged
Fix undefined tpl vars #20684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| if ($this->_showFeeBlock) { | ||
| $this->assign('showFeeBlock', TRUE); | ||
| $isMonetary = CRM_Core_DAO::getFieldValue('CRM_Event_DAO_Event', $this->_showFeeBlock, 'is_monetary'); |
There was a problem hiding this comment.
This PR looks ok as-is just am a little confused at how this was coming up undefined in the tpl because there's a default set at line 273.
There was a problem hiding this comment.
I think it wasn't - it was showing as a pattern in php land - FWIW my thinking is that we can separate this craziness out by building on #20679 with a PR that creates a new FeeBlock form that is a subform of this one. There is so much to unravel & I've been trying to figure out how to break it down & I think that will work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure variables referenced in the template are defined.
Followup from #20664