Fix test to use valid financials #20676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test tries to mimic a change in line items by just deleting the line items from a valid order. This fix switches to deleting the contribution and creating a new one with valid line items - which is what we would expect the code to do
|
(Standard links)
|
| @@ -485,6 +473,7 @@ public function validateAllCounts(int $membershipId, int $count): void { | |||
| $lineItemParams = [ | |||
| 'entity_id' => $membershipId, | |||
| 'entity_table' => 'civicrm_membership', | |||
| 'contribution_id' => ['>' => 0], | |||
There was a problem hiding this comment.
Because deleting a contribution leaves orphan line items - which might or might not be a good thing but out of scope of this change
|
It works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix test to use valid financials
Before
The test tries to mimic a change in line items by just deleting the line items from a valid order, creating an invalid order with mismatched financials
After
Switches to deleting the contribution and creating a new one with valid line items -
which is what we would expect 'real live' code to do
Technical Details
Fix towards extending financial verification
Comments