Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compact] Fix APIv4 Group Concat Test by setting dataType to be … #20655

Merged

Conversation

seamuslee001
Copy link
Contributor

…NULL if the first expression is a SQL Function

Overview

This fixes the following test failure on php8

api\v4\Action\SqlFunctionTest::testGroupAggregates
Failed asserting that an array contains '1, 122, 100.00'.

/home/jenkins/bknix-edge/build/build-2/web/sites/all/modules/civicrm/tests/phpunit/api/v4/Action/SqlFunctionTest.php:95
/home/jenkins/bknix-edge/extern/phpunit8/phpunit8.phar:671

Before

Test fails on php8

After

Test passes on php8

ping @colemanw

@civibot
Copy link

civibot bot commented Jun 18, 2021

(Standard links)

@civibot civibot bot added the master label Jun 18, 2021
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 this is snarled up in phpcs

@colemanw
Copy link
Member

The code looks good to me, when you get tests passing this is good to go.

…NULL if the first expression is a SQL Function
@seamuslee001 seamuslee001 force-pushed the fix_apiv4_group_concat_php8 branch from 9523926 to bc210cd Compare June 18, 2021 21:12
@seamuslee001 seamuslee001 merged commit bbb01e6 into civicrm:master Jun 18, 2021
@seamuslee001 seamuslee001 deleted the fix_apiv4_group_concat_php8 branch June 18, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants