Use mysql to set mailing.created_date #20630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
1921b94 to
cdd875b
Compare
|
This looks fine to me and @eileenmcnaughton I presume the upgrade process will remove the trigger? |
|
@eileenmcnaughton needs a rebase |
On digging I determined this trigger hokiness was all about mysql 5.5 and we can ditch it now https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html#mysqld-5-6-5-data-types and civicrm#10953 (comment) Note that we still support mysql 5.6 and the current version is 5.6.51 I think it's fine to require that the 5.6 minimum is 5.6.5 as released in 2012 I'll do the upgrade script as a follow up
cdd875b to
f6205b8
Compare
|
Done - thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use mysql to set mailing.created_date
Before
Trigger used to set the default value for mailing.created_date
After
mysql field default used
Technical Details
On digging I determined this trigger hokiness was all about mysql
5.5 and we can ditch it now
https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-5.html#mysqld-5-6-5-data-types
and #10953 (comment)
Note that we still support mysql 5.6 and the current version is 5.6.51
I think it's fine to require that the 5.6 minimum is 5.6.5 as released in 2012
Comments
@seamuslee001