Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[php8-compact][NFC] Update testGroupClause unit test to work on php8 #20624

Merged
merged 1 commit into from
Jun 16, 2021
Merged

[php8-compact][NFC] Update testGroupClause unit test to work on php8 #20624

merged 1 commit into from
Jun 16, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes the following test failure on php8

CRM_Contact_BAO_QueryTest::testGroupClause
1,1 includes 1
Failed asserting that false is true.

Before

Test fails on php8

After

Test passes on php8

ping @eileenmcnaughton @demeritcowboy @totten @colemanw

@civibot
Copy link

civibot bot commented Jun 16, 2021

(Standard links)

@civibot civibot bot added the master label Jun 16, 2021
@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor

I guess it still doesn't include 'OR'

@eileenmcnaughton eileenmcnaughton merged commit 2683025 into civicrm:master Jun 16, 2021
@eileenmcnaughton eileenmcnaughton deleted the query_test_php8 branch June 16, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton