Add test validation for Membership & participant payments

[eileenmcnaughton]

Overview

Removes redundant line that creates a membership payment in the order api. This is already covered in order api tests but I also extended the validate test cover.

I think the participantPayment.create can go too but I think there are some test issues to address and I am only partially validating participant payments

Before

more silly code, less test cover

After

Reversed

Technical Details

The pledge lines are logically unreachable I believe as I don't believe we ever store the pledge_id in line_item.entity_id and tests indicate they are not reached via tests - #20604

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

r-run on local, looks great. Extended unit test, captures the workflow about recording entity payments.

[monishdeb]

@eileenmcnaughton test build failures https://test.civicrm.org/job/CiviCRM-Core-PR/41782/

Test Result (4 failures / +4)
api_v3_ContributionPageTest.testSubmitMembershipComplexPriceSetPaymentPaymentProcessorRecurInstantPayment
api_v3_ContributionTest.testRepeattransactionRenewMembershipOldMembership
api_v3_MembershipTest.testGetOptionsMembershipTypeID
api_v3_ProfileTest.testProfileSubmitCheckCaching

look related.

[eileenmcnaughton]

it passed!