Add file_exists check on loading services xml #20620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
I'm hitting an issue where we run unit tests on our own code base and this is hitting file-not-found We don't package the tests directory with the tarball so it's not there. The alternative is to move it to the Civi\test folder if it's important that it be there for non-core tests
b706e8e to
c199b7c
Compare
|
This seems fine to me but will let @totten weigh in on this one |
|
This has been merge-ready for 6 days - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I'm hitting an issue where we run unit tests on our own code base and this is hitting file-not-found
We don't package the tests directory with the tarball so it's not there.
The alternative is to move it to the Civi\test folder if it's important that
it be there for non-core tests
Before
Tests fail against file not found when running against tarball
After
no fail
Technical Details
@totten
Comments