Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#1191 [TEST] [NFC] Specify return in getAndCheck #20618

Merged
merged 1 commit into from
Jun 16, 2021
Merged

dev/core#1191 [TEST] [NFC] Specify return in getAndCheck #20618

merged 1 commit into from
Jun 16, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 16, 2021 •
edited
Loading

Overview

dev/core#1191 Specify return in getAndCheck

@civibot
Copy link

civibot bot commented Jun 16, 2021

(Standard links)

@civibot civibot bot added the master label Jun 16, 2021
@eileenmcnaughton eileenmcnaughton mentioned this pull request Jun 16, 2021
Closed
@eileenmcnaughton eileenmcnaughton changed the title Try adding a strict return function to getAndCheck dev/core#1191 Try adding a strict return function to getAndCheck Jun 16, 2021
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 this test fix up should be mergeable now

@seamuslee001
Copy link
Contributor

Looks good

@seamuslee001 seamuslee001 merged commit 8cf172f into civicrm:master Jun 16, 2021
@eileenmcnaughton eileenmcnaughton changed the title dev/core#1191 Try adding a strict return function to getAndCheck dev/core#1191 [TEST] [NFC] Specify return in getAndCheck Jun 16, 2021
@seamuslee001 seamuslee001 deleted the return2 branch June 16, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001