Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compact] Fix Array to String in formButtons in CRM_Core_FormTest #20608

Merged

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes the following test error

CRM_Core_FormTest::testOpeningForms with data set "Find Contacts" ('civicrm/contact/search?reset=1')
Array to string conversion

/home/jenkins/bknix-edge/build/build-1/web/sites/default/files/civicrm/templates_c/en_US/%%ED/ED7/ED78F5CC%%formButtons.tpl.php:44

Before

Test fails on php8 due to array to string conversion

After

Test passes on php8

ping @demeritcowboy @eileenmcnaughton @totten @colemanw

@civibot
Copy link

civibot bot commented Jun 15, 2021

(Standard links)

@civibot civibot bot added the master label Jun 15, 2021
@demeritcowboy
Copy link
Contributor

That's strange I can't reproduce the error locally with php 8 either in tests or opening the page in the browser. But in any case the location should be "bottom" here right? - since it's at the bottom. But otherwise looks fine.

@seamuslee001
Copy link
Contributor Author

@demeritcowboy I was only finding it when I ran the full suite CRM_AllTests

@seamuslee001 seamuslee001 force-pushed the fix_core_form_array_to_string branch from 79aca0e to e0c0744 Compare June 15, 2021 22:16
@seamuslee001
Copy link
Contributor Author

added MOP based on Dave's review and updated the location to be bottom

@eileenmcnaughton eileenmcnaughton merged commit c6aacd0 into civicrm:master Jun 16, 2021
@eileenmcnaughton eileenmcnaughton deleted the fix_core_form_array_to_string branch June 16, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants