Force cleanup of setting value type "checkboxes" when is empty

[sluc23]

Overview

When using a custom setting of type checkboxes, if there's no checked value in the group, it's not saved empty in the DB

Before

Add a custom setting type checkboxes in you extension with multiple options, go to to Generic Admin Form, and save any value. Then go back and uncheck all the boxes, the empty value is not saved in the DB, previous value remains.

After

Empty value is saved in the DB; if there's no box checked in the Generic Admin Form

Technical Details

Looks like the setting type checkboxes is not fully supported in Civi yet, (as a single checkbox), probably more PRs coming after this one to add more features to this useful setting type

Comments

I haven't found many implementations of custom settings of type checkboxes in the community, but it's fully documented as part of settings MetaData in docs, but still needs some love in the source code to fully work as expected.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I think this one could use your eye on it @eileenmcnaughton

[eileenmcnaughton]

Thanks @sluc23 - this makes sense